Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get creation date on the execution #1631

Closed
antho1404 opened this issue Feb 3, 2020 · 4 comments · Fixed by #1680
Closed

Get creation date on the execution #1631

antho1404 opened this issue Feb 3, 2020 · 4 comments · Fixed by #1680
Assignees
Labels
enhancement New feature or request

Comments

@antho1404
Copy link
Member

Right now the execution is "timeless", we have no way to know when the execution happened. We should have a "created_at" time set when the validator puts it in the block to be able to sort executions by time when we list them. Also, this will give us the possibility to actually filter by date of execution which would be really nice to debug.

Note: Creation date was initially present in the execution but got deleted for simplification purposes.

@antho1404 antho1404 added the enhancement New feature or request label Feb 3, 2020
@NicolasMahe
Copy link
Member

We could add the same feature to other resources as well.
It will actually solve issue #1590

@NicolasMahe NicolasMahe self-assigned this Feb 24, 2020
@krhubert
Copy link
Contributor

I would rather put the BlockId when execution was added, otheriwse we might have it :)

@NicolasMahe
Copy link
Member

Let's use ctx.BlockHeight() or ctx.BlockTime() using sdk.Context in handlers.

@antho1404
Copy link
Member Author

Block height is enough, we can get the time based on the block height but not the other way around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants