Add block height to execution data #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
feature/exeuction-block-height
branch
from
0e86baf
to
d0af8cc
Compare
NicolasMahe
reviewed
Feb 25, 2020
|
what about other resources? |
|
Let's do it on the executions first and see how it goes, I feel this is a bit hacky and we might not need it so I would like to see first with the execution if it's something really required before we touch other resources if we don't need it yet |
antho1404
approved these changes
Feb 25, 2020
We don't have a need for it right now. We can always add it later. |
NicolasMahe
approved these changes
Feb 26, 2020
NicolasMahe
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1631
dep #1670