Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core_provider.Stop() should get running services from the Core #496

Closed
NicolasMahe opened this issue Sep 24, 2018 · 2 comments
Closed

core_provider.Stop() should get running services from the Core #496

NicolasMahe opened this issue Sep 24, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Sep 24, 2018 •
edited
Loading

The CLI access directly the function service.ListRunning().
It should use the core API ServiceList to list the services and then stop them.
For now, ServiceList doesn't return the service's status. We can implement a first dummy version that try to stop ALL of them.
Then in the future, we can add the status to the ServiceList and stop only the running ones.

https://github.com/mesg-foundation/core/blob/c3e23fd91747f05750f9f18c699bb4910a082b7e/commands/provider/core_provider.go#L33-L66
@NicolasMahe NicolasMahe added bug Something isn't working CLI labels Sep 24, 2018
@ilgooz ilgooz self-assigned this Sep 25, 2018
ilgooz added a commit that referenced this issue Sep 25, 2018
@ilgooz
extend ListServices api to filter by running services, closes #496
105bea6 
* coreapi.Service type know has IsRunning field, relevant APIs accordingly updated to set this value.
* update dev-core script.
* update database/services API to filter services by id, fix & add tests.
ilgooz added a commit that referenced this issue Sep 25, 2018
@ilgooz
extend ListServices api to filter by running services, closes #496
f39eaa5 
* coreapi.Service type know has IsRunning field, relevant APIs accordingly updated to set this value.
* update dev-core script.
* update database/services API to filter services by id, add more tests.
ilgooz added a commit that referenced this issue Sep 25, 2018
@ilgooz
extend ListServices api to filter by running services, closes #496
0c79710 
* coreapi.Service type know has IsRunning field, relevant APIs accordingly updated to set this value.
* update dev-core script.
* update database API to filter services by id, add more tests.
@ilgooz ilgooz removed their assignment Oct 1, 2018
@ilgooz
Copy link
Contributor

ilgooz commented Oct 1, 2018 •
edited
Loading

should re-open after #499 is merged, this issue will be closed by another PR.

@antho1404
Copy link
Member

I would actually keep that one but maybe change it a bit to say that the core itself when it stops should stop the running services. The actual solution of fetching the list of services and stop them all is good enough for now but it will change.

antho1404 added a commit that referenced this issue Oct 3, 2018
@antho1404
Merge pull request #499 from mesg-foundation/feature/service-list
0f695e6 
extend ListServices api to filter by running services, closes #496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antho1404 @NicolasMahe @ilgooz