Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default database path on breaking changes #882

Closed
ilgooz opened this issue Apr 16, 2019 · 5 comments · Fixed by #905
Closed

update default database path on breaking changes #882

ilgooz opened this issue Apr 16, 2019 · 5 comments · Fixed by #905
Assignees

Comments

@ilgooz
Copy link
Contributor

ilgooz commented Apr 16, 2019

this is needed by the next release, because we're breaking it now since we don't nil check the Configuration in Service anymore. in the past versions it wasn't filled and now we always set it

@ilgooz ilgooz added bug Something isn't working breaking change and removed bug Something isn't working labels Apr 16, 2019
@antho1404
Copy link
Member

@NicolasMahe
Copy link
Member

NicolasMahe commented Apr 22, 2019

@krhubert can you take care of this issue please?

It should be solve by adding a constant version to the path of the dbs in config (see Anthony's post).

@krhubert
Copy link
Contributor

Yep, sure

@NicolasMahe
Copy link
Member

@antho1404 should the db service and the db execution have the same or different version?
I guess different. Can you confirm.

@antho1404
Copy link
Member

antho1404 commented Apr 22, 2019

yes different version for each resources. We don't need to "deprecate" the database of execution if there is no impacts on it and the same with the services

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants