Add version to databases path #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
feature/db-versioning
branch
from
f52364a
to
60e2169
Compare
NicolasMahe
approved these changes
Apr 22, 2019
ilgooz
approved these changes
Apr 22, 2019
antho1404
requested changes
Apr 22, 2019
There was a problem hiding this comment.
- Download last version of mesg-core (v0.8.1)
- Deploy a new service with mesg-core
- List services with
./dev-cli service list
Expected:
empty list of services
Actual:
➜ core git:(feature/db-versioning) ✗ ./dev-cli service list
rpc error: code = Internal desc = grpc: failed to unmarshal the received message unexpected EOF
mine works. you're not using ./dev-core and this pr is not backward compatible. do we care about backward compatibility for this one? I think we shouldn't care about it in this stage. |
|
This PR is only about adding path to core db and mine is work as well |
antho1404
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #882