Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev-core command #1002

Merged
merged 5 commits into from
May 30, 2019
Merged

Fix dev-core command #1002

merged 5 commits into from
May 30, 2019

Conversation

antho1404
Copy link
Member

@antho1404 antho1404 commented May 30, 2019 •
edited by NicolasMahe
Loading

Will merge to #991

@antho1404 antho1404 mentioned this pull request May 30, 2019
Merged
NicolasMahe
NicolasMahe previously approved these changes May 30, 2019
View reviewed changes
NicolasMahe
NicolasMahe reviewed May 30, 2019
View reviewed changes
dev-core Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe reviewed May 30, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deleting my local bin folder, the Dockerfile.dev need to be updated:

COPY ./bin/core .
CMD [ "./core" ]

to

COPY ./bin/engine .
CMD [ "./engine" ]

@NicolasMahe NicolasMahe dismissed their stale review May 30, 2019 05:26

checked to fast

@NicolasMahe
Copy link
Member

I did the modif myself.

Make sure to delete the bin folder in the engine folder to test properly ;)

@NicolasMahe NicolasMahe mentioned this pull request May 30, 2019
Merged
@antho1404 antho1404 merged commit 1f0f8d9 into rename-engine May 30, 2019
@antho1404 antho1404 deleted the feature/rename-engine-2 branch May 30, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antho1404 @NicolasMahe