Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename script dev-core to dev #1004

Merged
merged 1 commit into from
May 31, 2019
Merged

Rename script dev-core to dev #1004

merged 1 commit into from
May 31, 2019

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented May 30, 2019 •
edited
Loading

Dependant on #1003

@NicolasMahe NicolasMahe changed the base branch from rename-engine to dev May 30, 2019 07:06
@antho1404
Copy link
Member

dev-core still exists and there are differences between both

➜  engine git:(rename-dev-core-to-dev) diff dev-core dev
15c15
< networkExists=$(docker network list -f name=^engine$ -f driver=overlay -q)
---
> networkExists=$(docker network list -f name=engine -f driver=overlay -q)

@NicolasMahe
Copy link
Member Author

dev-core still exists and there are differences between both

➜  engine git:(rename-dev-core-to-dev) diff dev-core dev
15c15
< networkExists=$(docker network list -f name=^engine$ -f driver=overlay -q)
---
> networkExists=$(docker network list -f name=engine -f driver=overlay -q)

fixed

@antho1404 antho1404 merged commit 535b4f3 into dev May 31, 2019
@antho1404 antho1404 deleted the rename-dev-core-to-dev branch May 31, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@krhubert krhubert Awaiting requested review from krhubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasMahe @antho1404