Implement execution service #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
feature/exeuction-api-sdk
branch
2 times, most recently
from
368d4fb
to
f2cb87d
Compare
NicolasMahe
reviewed
Jun 2, 2019
NicolasMahe
reviewed
Jun 2, 2019
|
@krhubert can you add the dependency to other PR |
krhubert
force-pushed
the
feature/exeuction-api-sdk
branch
4 times, most recently
from
17ab8b9
to
7c12d71
Compare
|
Could the new functions in sdk be moved to sdk/execution sub-package as describe in https://forum.mesg.com/t/execution-db-and-api/280 and https://forum.mesg.com/t/sdk-package-organisation/299 ? EDIT: also apply the same logic for |
8 tasks
krhubert
force-pushed
the
feature/exeuction-api-sdk
branch
from
cbff945
to
ea81b4a
Compare
NicolasMahe
approved these changes
Jun 4, 2019
antho1404
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dep #1006
This is one intentional bug here.there is one to one mapping of status in protobuf and execution.To fix this I want to change execution status to beored and also replace slice of status in execution filter to just status int.EDIT:
status value was change to one coresponding in execution package.