added instancesdk.List() feature and its gRPC API #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and added GetAllByService() method to instance database.
NicolasMahe
requested changes
Jun 20, 2019
ilgooz
force-pushed
the
feature/instance-list
branch
2 times, most recently
from
53333bf
to
2722db7
Compare
so serviceHash can be optional. * database/instancedb: added GetAll().
ilgooz
force-pushed
the
feature/instance-list
branch
from
2722db7
to
a86916d
Compare
NicolasMahe
approved these changes
Jun 21, 2019
antho1404
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1074