Implement List for Service #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
why using a stream here. We don't have any pub/sub system for services yet so there is no reason to have a stream here. Let's simplify and return a list of services directly and let grpc/protobuf handle that |
|
@krhubert I agree with Anthony. A stream seems overkill for now.. Let's develop the simplest api we can. |
krhubert
force-pushed
the
feature/service-list
branch
from
0618aa0
to
8e73c14
Compare
NicolasMahe
reviewed
Jun 24, 2019
|
|
||
| resp := &protobuf_api.ListServiceResponse{} | ||
| for _, service := range services { | ||
| resp.Services = append(resp.Services, ToProtoService(service)) |
There was a problem hiding this comment.
I think there is a ToProtoServices function. Let's use it or remove it.
NicolasMahe
approved these changes
Jun 24, 2019
antho1404
approved these changes
Jun 24, 2019
|
|
||
| resp := &protobuf_api.ListServiceResponse{} | ||
| for _, service := range services { | ||
| resp.Services = append(resp.Services, ToProtoService(service)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dep on: #1072