Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace execution serviceHash by instanceHash #1106

Merged
merged 10 commits into from
Jun 26, 2019
Merged

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Jun 25, 2019

Closes #1084

@krhubert you are welcome to continue this PR ;)

@krhubert krhubert marked this pull request as ready for review June 25, 2019 21:15
@NicolasMahe NicolasMahe changed the title [WIP] Replace execution serviceHash by instanceHash Replace execution serviceHash by instanceHash Jun 26, 2019
sdk/execution/execution.go Outdated Show resolved Hide resolved
sdk/execution/execution_test.go Show resolved Hide resolved
@krhubert krhubert requested a review from antho1404 June 26, 2019 05:28
@NicolasMahe
Copy link
Member Author

I approve this PR (cannot use Github function because I created the PR).

Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some work to do on the apis to have a full working execution api but this pr is valid

@antho1404 antho1404 merged commit e794aa8 into dev Jun 26, 2019
@antho1404 antho1404 deleted the fix/execution-servicehash branch June 26, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execution needs to use Instance instead of Service hash
3 participants