clean proto service #1128

krhubert · 2019-06-27T11:29:48Z

No description provided.

antho1404

Because Service api is removed we can now rename ServiceX into Service

server/grpc/api/event.go

sdk/event/event.go

protobuf/coreapi/api.proto

krhubert added 7 commits June 27, 2019 13:11

Remove client

0020eb9

Remove obsolete proto api

ca8f9cb

Regenerate proto files

190ea56

Do not use obsolete api in grpc servers

46c26ef

Rename event Emit to Create

4ca7fa3

Simplfiy grpc server api

5e37be3

Fix tests

56b42bc

krhubert requested review from antho1404 and NicolasMahe and removed request for antho1404 and NicolasMahe June 27, 2019 11:31

krhubert added 3 commits June 27, 2019 13:55

Do not build serviceapi proto

72c08bd

Rename definition to types in protobuf

f3fee40

Use types instead of definition

d8662cc

antho1404 reviewed Jun 27, 2019

View reviewed changes

server/grpc/api/event.go Outdated Show resolved Hide resolved

sdk/event/event.go Show resolved Hide resolved

krhubert added 2 commits June 27, 2019 17:22

Rename ServiceX to Service

e1a11e0

Create event in sdk instead of server

1a751be

antho1404 reviewed Jun 27, 2019

View reviewed changes

protobuf/coreapi/api.proto Show resolved Hide resolved

Merge branch 'dev' into refactor/clean-proto-service

1eb95c0

antho1404 approved these changes Jun 28, 2019

View reviewed changes

NicolasMahe approved these changes Jun 28, 2019

View reviewed changes

NicolasMahe merged commit 7a6207f into dev Jun 28, 2019

NicolasMahe deleted the refactor/clean-proto-service branch June 28, 2019 04:16

Provide feedback