Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganization of service package #1185

Merged
merged 5 commits into from
Jul 16, 2019
Merged

Reorganization of service package #1185

merged 5 commits into from
Jul 16, 2019

Conversation

antho1404
Copy link
Member

  • Extract ValidateService in its own validator package
  • Move all types in a file type.go
  • Remove non used struct/error/functions (Log struct, ValidateConfigurationEnv and ErrNotDefinedEnv)

@antho1404 antho1404 added this to the next milestone Jul 16, 2019
@antho1404 antho1404 self-assigned this Jul 16, 2019
krhubert
krhubert reviewed Jul 16, 2019
View reviewed changes
sdk/service/service.go Outdated Show resolved Hide resolved
service/service.go Show resolved Hide resolved
service/service.go Show resolved Hide resolved
service/service.go Show resolved Hide resolved
service/validator/validator.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe approved these changes Jul 16, 2019
View reviewed changes
service/type.go Outdated Show resolved Hide resolved
service/type.go Outdated Show resolved Hide resolved
service/service.go Show resolved Hide resolved
@antho1404 antho1404 mentioned this pull request Jul 16, 2019
Merged
@antho1404 antho1404 force-pushed the refactoring/service-package branch from 0b557f9 to 7f0b9a4 Compare July 16, 2019 10:33
@antho1404 antho1404 mentioned this pull request Jul 16, 2019
Closed
@antho1404 antho1404 merged commit cee1787 into dev Jul 16, 2019
@antho1404 antho1404 deleted the refactoring/service-package branch July 16, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert left review comments

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees

@antho1404 antho1404

Labels
refactoring
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@antho1404 @krhubert @NicolasMahe