Replace json format with protobuf Struct

[krhubert]

fix #1176

[antho1404]

I don't understand why you don't directly use import "google/protobuf/struct.proto";
Now because you use your own struct this is not recognized by proto and it will not do any processing on the message but if you use the one from google you should have pretty much nothing to do.

If I compile with the official struct I have in my generated file a new type imported _struct "github.com/golang/protobuf/ptypes/struct"

Also, please description, labels, issue solved, project related on the pull requests ;)

[krhubert]

I don't understand why you don't directly use import "google/protobuf/struct.proto";

google/protobuf/struct.proto: File not found.
protobuf/types/event.proto:3:1: Import "google/protobuf/struct.proto" was not found or had errors.

We have to pass path to struct when building (flag --proto_path) and we don't keep protobuf definitions in repo. We have to copy it somewhere (so I did it with just few modifications)

Now because you use your own struct this is not recognized by proto and it will not do any processing on the message but if you use the one from google you should have pretty much nothing to do.

What do you mean "is not recognized by proto"/"will not do any processing on the message" - any more info.

If I compile with the official struct I have in my generated file a new type imported _struct "github.com/golang/protobuf/ptypes/struct"

Yes, the import path is different (if this is what you mean) because the go_package in the officaial file is different. But they are pretty much the same after generation.

https://github.com/golang/protobuf/blob/master/ptypes/struct/struct.pb.go

Also, please description, labels, issue solved, project related on the pull requests ;)

Sure :)

[krhubert]

fix #1176

wip: need to fix ethwallet as well.

[NicolasMahe]

is it needed?

[krhubert]

Ok I think I'm done here, only tests left but for tests I need cli updated @NicolasMahe @antho1404 can you prepare an update of cli so I can test eth wallet and marketplace?

[antho1404]

can't this be tested just with the api? Also is this ready to review? there is still the wip label? Please also add details on this PR as discussed

[krhubert]

can't this be tested just with the api?

I don't know because it might be hard to pass protobuf.Struct as an option via grpcurl tool.
So I need to check if this can be tested with just api but mesg-cli needs an update anyway, so why to test it twice, if this could be done with mesg-cli.

Also is this ready to review? there is still the wip label?

It's ready for review, but it's not tested this is why I left wip label.

[antho1404]

This would actually make grpcurl easier because we don't have to json stringify the inputs and just pass them in a map directly.

example:

grpcurl -plaintext -d "{\"instanceHash\":\"6LfmaGAKcpGT93z6fMp1PVqraCbXstWwaSwM7HdvfgPp\", \"taskKey\":\"taskX\", \"inputs\":{\"foo\": \"hello\", \"bar\":\"world\"}}" localhost:50052 api.Execution/Create

instead of something like

grpcurl -plaintext -d "{\"instanceHash\":\"6LfmaGAKcpGT93z6fMp1PVqraCbXstWwaSwM7HdvfgPp\", \"taskKey\":\"taskX\", \"inputs\":\"{\\\"foo\\\": \\\"hello\\\", \\\"bar\\\":\\\"world\\\"}\"}" localhost:50052 api.Execution/Create

Also yes cli and lib needs to be updated when this development is finished and tested

---

You did update the ethwallet service so you could do the tests with this service and execute tasks/events to see if everything works fine.

From my tests, it doesn't work

grpcurl -plaintext -d "{\"instanceHash\":\"Hsy6y2i7ZxrTMHFb39sm1bLrSB2QenjXEcGKcNjb7kbw\", \"taskKey\":\"list\", \"inputs\":{}}" localhost:50052 api.Execution/Create

My execution stays in progress

[antho1404]

I have a lot of issues testing with the ethwallet service (that is the only one updated with the new api)

Example:

Invalid inputs for the list task

grpcurl -plaintext -d "{\"instanceHash\":\"Hsy6y2i7ZxrTMHFb39sm1bLrSB2QenjXEcGKcNjb7kbw\", \"taskKey\":\"list\", \"inputs\":{\"passphrase\":\"1\"}}" localhost:50052 api.Execution/Create

No errors in the engine, execution with the passphrase as input and still in pending.

Generate a new address

grpcurl -plaintext -d "{\"instanceHash\":\"Hsy6y2i7ZxrTMHFb39sm1bLrSB2QenjXEcGKcNjb7kbw\", \"taskKey\":\"create\", \"inputs\":{\"passphrase\":\"1\"}}" localhost:50052 api.Execution/Create

Execution working but with an error invalid character '\\x11' looking for beginning of value

[NicolasMahe]

Invalid inputs for the list task

grpcurl -plaintext -d "{\"instanceHash\":\"Hsy6y2i7ZxrTMHFb39sm1bLrSB2QenjXEcGKcNjb7kbw\", \"taskKey\":\"list\", \"inputs\":{\"passphrase\":\"1\"}}" localhost:50052 api.Execution/Create

No errors in the engine, execution with the passphrase as input and still in pending.

This is not related to this PR. The Engine only check for required data and their type, not for data that are not declared by the task.

[antho1404]

sure but the execution should be completed and it is not but I agree, the parameter is irrelevant

[NicolasMahe]

This is a big breaking change but I'm ok to release it in this week release though :) It's really nicer.

I'm excited to see the simplification on the js lib :)

[mesg-bot]

This pull request has been mentioned on MESG Community. There might be relevant details there:

https://forum.mesg.com/t/release-notes-of-engine-v0-12-cli-v1-2-and-js-library-v4-2/367/1