Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cosmos modules #1219

Merged
merged 26 commits into from
Aug 14, 2019
Merged

Add cosmos modules #1219

merged 26 commits into from
Aug 14, 2019

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Aug 13, 2019 •
edited
Loading

  • Replace cosmos app by the one from cosmos tuto
  • Generate the genesis with the default app state of modules
  • Create an cosmos account
  • Add this account to the genesis of account module
  • Generate a CreateValidator transaction to add the account as validator of the chain
  • Generate the genesis using all previous info

To do in other PR:

@NicolasMahe NicolasMahe added the enhancement New feature or request label Aug 13, 2019
@NicolasMahe NicolasMahe added this to the next milestone Aug 13, 2019
@NicolasMahe NicolasMahe self-assigned this Aug 13, 2019
@NicolasMahe NicolasMahe changed the title Add cosmos managers Add cosmos modules Aug 13, 2019
@NicolasMahe NicolasMahe marked this pull request as ready for review August 13, 2019 09:18
@krhubert
Copy link
Contributor

Are we ready to merge this one?

@NicolasMahe
Copy link
Member Author

yes but waiting for antho to check a bit

antho1404
antho1404 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% of some stuff like the part you send the transaction but I know you are working on it on another PR so that's fine

tendermint/app/app.go

// register the staking hooks
// NOTE: stakingKeeper above is passed by reference, so that it will contain these hooks
app.stakingKeeper = *stakingKeeper.SetHooks(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this SetHooks for? I don't remember seeing anything on that

@antho1404 antho1404 merged commit 07e09fd into dev Aug 14, 2019
@antho1404 antho1404 deleted the cosmos/app-managers branch August 14, 2019 08:58
@NicolasMahe NicolasMahe modified the milestones: next, v0.13.0 Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@krhubert krhubert krhubert approved these changes

Assignees

@NicolasMahe NicolasMahe

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasMahe @krhubert @antho1404