Transform service sdk to accept cosmos service step 1 #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NicolasMahe
commented
Aug 22, 2019
•
NicolasMahe
commented
- Add service sdk interface
- Rename current implementation to deprecated
antho1404
requested changes
Aug 22, 2019
There was a problem hiding this comment.
➜ engine git:(cosmos/service-sdk-step-1) ./dev
compile engine
# github.com/mesg-foundation/engine/sdk/instance
sdk/instance/instance.go:75:23: i.service.Get undefined (type *servicesdk.Service is pointer to interface, not interface)
sdk/instance/start.go:12:23: i.service.Get undefined (type *servicesdk.Service is pointer to interface, not interface)
sdk/instance/stop.go:13:23: i.service.Get undefined (type *servicesdk.Service is pointer to interface, not interface)
sdk/instance/volume.go:18:21: i.service.Get undefined (type *servicesdk.Service is pointer to interface, not interface)
…ementation to deprecated
NicolasMahe
force-pushed
the
cosmos/service-sdk-step-1
branch
from
b09d3cb
to
722de33
Compare
fixed |
|
This pull request has been mentioned on MESG Community. There might be relevant details there: https://forum.mesg.com/t/network-implementation-with-cosmossdk/304/15 |
antho1404
approved these changes
Aug 22, 2019
krhubert
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.