Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change proto hash type from string to bytes #1270

Merged
merged 7 commits into from
Aug 30, 2019
Merged

Change proto hash type from string to bytes #1270

merged 7 commits into from
Aug 30, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Aug 28, 2019 •
edited
Loading

close #1265

@krhubert krhubert force-pushed the refactor/hash-string-to-bytes branch from 23e20a3 to f727c82 Compare August 28, 2019 18:40
@krhubert krhubert self-assigned this Aug 28, 2019
@krhubert krhubert added this to the next milestone Aug 28, 2019
@krhubert krhubert force-pushed the refactor/hash-string-to-bytes branch 2 times, most recently from b7f3cc2 to 1704838 Compare August 28, 2019 18:47
@krhubert krhubert requested review from antho1404 and NicolasMahe and removed request for antho1404 August 28, 2019 18:48
@krhubert krhubert marked this pull request as ready for review August 28, 2019 18:48
NicolasMahe
NicolasMahe reviewed Aug 29, 2019
View reviewed changes
hash/hash.go Show resolved Hide resolved
protobuf/types/service.proto Show resolved Hide resolved
sdk/service/utils.go Outdated Show resolved Hide resolved
@NicolasMahe
Copy link
Member

NicolasMahe commented Aug 29, 2019 •
edited
Loading

I did all the service's hash modification from string to []byte in this commit: 281dd92
maybe you could just revert it to really revert all the hack i did ;)

@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label Aug 29, 2019
@krhubert krhubert force-pushed the refactor/hash-string-to-bytes branch from 1704838 to 3bccb62 Compare August 29, 2019 05:39
@krhubert krhubert force-pushed the refactor/hash-string-to-bytes branch from 3bccb62 to 8738868 Compare August 29, 2019 05:42
NicolasMahe
NicolasMahe approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the modification but we need to wait for at least a PR on the mesg-js or cli to make them work with those modifications!

@NicolasMahe NicolasMahe mentioned this pull request Aug 29, 2019
Merged
@NicolasMahe NicolasMahe mentioned this pull request Aug 29, 2019
Merged
@NicolasMahe
Copy link
Member

mesg-js and cli updated in PRs: mesg-foundation/mesg-js#124 and mesg-foundation/cli#138.
@mesg-foundation/mesg-core-team please review and test so we can merge all at once!

NicolasMahe
NicolasMahe reviewed Aug 30, 2019
View reviewed changes
hash/hash.go Outdated Show resolved Hide resolved
@krhubert krhubert force-pushed the refactor/hash-string-to-bytes branch from e6da050 to 291b3b7 Compare August 30, 2019 08:32
@krhubert krhubert force-pushed the refactor/hash-string-to-bytes branch from 291b3b7 to d1d5aa5 Compare August 30, 2019 08:35
@NicolasMahe NicolasMahe merged commit a80d90c into dev Aug 30, 2019
@NicolasMahe NicolasMahe deleted the refactor/hash-string-to-bytes branch August 30, 2019 10:35
@antho1404 antho1404 mentioned this pull request Aug 30, 2019
Closed
@NicolasMahe NicolasMahe removed the release:change Pull requests that change something existant label Sep 4, 2019
@NicolasMahe NicolasMahe mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees

@krhubert krhubert

Labels
breaking change refactoring
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

Set type of all hash to bytes in protobuf files
3 participants
@krhubert @NicolasMahe @antho1404