Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marshal issue with process filter #1286

Merged
merged 3 commits into from
Sep 2, 2019
Merged

Fix marshal issue with process filter #1286

merged 3 commits into from
Sep 2, 2019

Conversation

antho1404
Copy link
Member

When creating a new process with filters, the filter was not correctly marshaled/unmarshaled.

@antho1404 antho1404 added the bug Something isn't working label Sep 2, 2019
@antho1404 antho1404 added this to the next milestone Sep 2, 2019
@antho1404 antho1404 self-assigned this Sep 2, 2019
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to test but it compiles..

@antho1404
Copy link
Member Author

@NicolasMahe I added some tests on the PR to check the behavior, that was added in another PR but probably a wrong merge...

@antho1404 antho1404 merged commit 74acfd7 into dev Sep 2, 2019
@antho1404 antho1404 deleted the bug/filter-marshaling branch September 2, 2019 10:37
@NicolasMahe NicolasMahe added release:fix Pull requests that fix something release:change Pull requests that change something existant and removed release:fix Pull requests that fix something labels Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release:change Pull requests that change something existant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants