Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy of folder in dev script #1360

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Fix copy of folder in dev script #1360

merged 2 commits into from
Sep 25, 2019

Conversation

krhubert
Copy link
Contributor

As showed here cp works differently on linux and mac. This fix replaces cp with rsync to make behave the same.

to test run:

./dev --exp --validator

and make sure node is a validator

@krhubert krhubert added the bug Something isn't working label Sep 25, 2019
@krhubert krhubert added this to the next milestone Sep 25, 2019
@krhubert krhubert self-assigned this Sep 25, 2019
@NicolasMahe NicolasMahe merged commit c698a96 into dev Sep 25, 2019
@NicolasMahe NicolasMahe deleted the fix/dev-script branch September 25, 2019 10:56
@NicolasMahe NicolasMahe changed the title Use rsync to copy a file Fix copy of folder in dev script Oct 25, 2019
@NicolasMahe NicolasMahe added the release:fix Pull requests that fix something label Oct 25, 2019
@NicolasMahe NicolasMahe mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@antho1404 antho1404 Awaiting requested review from antho1404

Assignees

@krhubert krhubert

Labels
bug Something isn't working release:fix Pull requests that fix something
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@krhubert @NicolasMahe