Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove system services and deprecated service sdk #1361

Merged
merged 4 commits into from
Sep 26, 2019
Merged

Remove system services and deprecated service sdk #1361

merged 4 commits into from
Sep 26, 2019

Conversation

krhubert
Copy link
Contributor

close #1351

  • remove deprecated service sdk
  • remove experimental-network flag
  • keep experimental flag in dev script (in go code was removed because linter complains that variable is unused - to add when needed)
  • remove support for system services (dev script, deploy, config, core info api)
  • refactor config package (remove singleton)

TODO:

  • one test from execution package was commented. We need to figure out how we want to approach testing of service sdk (and features sdk services) which will be done on tm network.

@krhubert krhubert added this to the next milestone Sep 25, 2019
@krhubert krhubert self-assigned this Sep 25, 2019
NicolasMahe
NicolasMahe approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾 good PR and good simplification of Config 🍾
My comment on core api is not blocking ;) I will convert to an issue.

protobuf/coreapi/api.proto Show resolved Hide resolved
@NicolasMahe NicolasMahe mentioned this pull request Sep 26, 2019
Closed
@krhubert krhubert mentioned this pull request Sep 26, 2019
Merged
This was referenced Sep 26, 2019
Merged
Closed
@antho1404 antho1404 merged commit 3f620fd into dev Sep 26, 2019
@antho1404 antho1404 deleted the refactor/sdk-deprecated branch September 26, 2019 16:13
@NicolasMahe NicolasMahe changed the title Refactor sdk deprecated and system services Remove system services and deprecated service sdk Oct 25, 2019
@NicolasMahe NicolasMahe mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees

@krhubert krhubert

Labels
breaking change refactoring
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Remove deprecated service sdk
3 participants
@krhubert @antho1404 @NicolasMahe