Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service deletion function #1381

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Conversation

krhubert
Copy link
Contributor

close #1378

@krhubert krhubert added the enhancement New feature or request label Sep 30, 2019
@krhubert krhubert added this to the next milestone Sep 30, 2019
@krhubert krhubert self-assigned this Sep 30, 2019
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial idea was to only throw a "not implemented error", I'm fine with deleting it but in that case, we should also delete at the store level

@antho1404
Copy link
Member

Also just as a note, we can always delete a service with the following steps:

  • Export all the services with service:detail command
  • Delete ./mesg/database
  • Reimport all the exported services except the one we want to delete

It's kind of hardcore but there's a way.

@krhubert
Copy link
Contributor Author

Also just as a note, we can always delete a service with the following steps:

I don't get you. Yes we can do that, but it will only delete the service from your local database. And when node connects to the network, the database will be sync with that service again.

@antho1404
Copy link
Member

I was just talking in the case of a local dev network ;)

@NicolasMahe NicolasMahe merged commit 034602b into dev Sep 30, 2019
@NicolasMahe NicolasMahe deleted the feature/remove-service-del branch September 30, 2019 13:04
@NicolasMahe NicolasMahe changed the title Remove service deletion Remove service deletion function Oct 25, 2019
@NicolasMahe NicolasMahe mentioned this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove delete service function
3 participants