Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve use of proto Value and remove one of on UpdateExecutionRequest #1499

Merged
merged 5 commits into from
Nov 13, 2019
Merged

Improve use of proto Value and remove one of on UpdateExecutionRequest #1499

merged 5 commits into from
Nov 13, 2019

Conversation

antho1404
Copy link
Member

Modification to make sure we always only use the mesg.protobuf.Value type and not the internal types like ListValue.
Also, remove the oneof for the UpdateExecutionRequest this allows using the repeated Value and we will have a better error context

@antho1404 antho1404 added the enhancement New feature or request label Nov 12, 2019
@antho1404 antho1404 added this to the next milestone Nov 12, 2019
@antho1404 antho1404 self-assigned this Nov 12, 2019
@NicolasMahe NicolasMahe merged commit 62ddc9b into feature/remove-proto-map Nov 13, 2019
@NicolasMahe NicolasMahe deleted the feature/remove-proto-map-2 branch November 13, 2019 09:31
@NicolasMahe NicolasMahe changed the title Improve use of Value Improve use of proto Value and remove one of on UpdateExecutionRequest Nov 26, 2019
@NicolasMahe NicolasMahe mentioned this pull request Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert approved these changes

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees

@antho1404 antho1404

Labels
breaking change enhancement New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@antho1404 @krhubert @NicolasMahe