Add e2e tests of a complex service #1500
Conversation
|
Why not implementing the complex service directly in the current e2e test service? |
|
To split the tests services and not put everthing into one. You test also deploying multiple services and we still might use them to test process. Also as you can see there was a pbm with deleting 2nd of them which wouldn't came up when I would implement that in one service. |
e2e/complex_service_test.go
Outdated
|
|
||
| service, err := client.ServiceClient.Get(ctx, &pb.GetServiceRequest{Hash: testServiceHash}) | ||
| require.NoError(t, err) | ||
| want := pb.TransformCreateReqToService(req) |
There was a problem hiding this comment.
I don't like this protobuf.TransformCreateReqToService.
The hash calculation should be done by the service sdk.
And I don't think it makes sense to check if the hash is expected. This is a e2e tests, not a unit test.
There was a problem hiding this comment.
I suggest to revert this function and not check the expected service hash.
There was a problem hiding this comment.
Ok we don't need to check it. But TransformCreateReqToService should there, but maybe without hash calculation. Sdk pachage shoudn't have logic how transform pb structures
There was a problem hiding this comment.
With the discussion of the last meeting, we spoke about bringing the requests closer to the sdk..
There was a problem hiding this comment.
The request yes, but this is transformation and it's different.
krhubert
force-pushed
the
test/e2e-complex-service
branch
from
d798684
to
6aba629
Compare
|
@NicolasMahe I've tried to debug it without success, can you take a look on that for few mins? |
…-complex-service # Conflicts: # e2e/testdata/test-service.json
NicolasMahe
force-pushed
the
test/e2e-complex-service
branch
from
a66ade6
to
e3c0223
Compare
I improved the test and revert c0ab023 but could not figure how to fix this issue. So the test is now skipped with a FIXME message. The problem occurs only on the CI and only with a service with at least one dependency. It looks like the dependency is server killed and thus the service is never stopped. I will create an issue and investigate later as it is not blocking. |
NicolasMahe
changed the title
More complex service test for #1446