Fix hash length #1504
Merged
Fix hash length #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he actual length.
antho1404
approved these changes
Nov 15, 2019
krhubert
reviewed
Nov 15, 2019
| @@ -19,6 +19,13 @@ var DefaultHash = sha256.New | |||
| // size is a default size for hashing algorithm. | |||
| var size = DefaultHash().Size() | |||
|
|
|||
| func checkLen(data []byte) error { | |||
| if len(data) != size { | |||
There was a problem hiding this comment.
if this is hash.Hahs length it should be in hash package , what do you think?
There was a problem hiding this comment.
This function is used with different parameters: 2 with directly Hash, 2 with []byte.
So it doesn't make sense to put it as a struct function (func (h *Hash) checkLen(data []byte) error {).
it should be in hash package
it's already in hash package.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the length of hash in Marshal and Unmarshal and return always the actual length.
I had the issue where the Marshal function accepted a hash with the wrong length, and the unmarshal function was return an unrecognized EOF error because the length return by the hash was hardcoded...