Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove service env MESG_TOKEN #1513

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Remove service env MESG_TOKEN #1513

merged 1 commit into from
Nov 19, 2019

Conversation

NicolasMahe
Copy link
Member

Remove service env MESG_TOKEN until a real auth system is put in place

@NicolasMahe NicolasMahe added this to the next milestone Nov 19, 2019
@NicolasMahe NicolasMahe self-assigned this Nov 19, 2019
@NicolasMahe NicolasMahe merged commit 0b000a8 into dev Nov 19, 2019
@NicolasMahe NicolasMahe deleted the feature/remove-mesg-token branch November 19, 2019 05:20
@antho1404
Copy link
Member

Why this has been merged without approval?
We shouldn't remove this injected env variable. Without this, the service doesn't know what to communicate back to the engine.
This needs to be reverted also I'm pretty sure that tests will fail on this one but you didn't wait for it

@antho1404 antho1404 mentioned this pull request Nov 19, 2019
Merged
@NicolasMahe NicolasMahe mentioned this pull request Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 Awaiting requested review from antho1404

@krhubert krhubert Awaiting requested review from krhubert

Assignees

@NicolasMahe NicolasMahe

Labels
breaking change
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasMahe @antho1404