Decentralization of the processes #1527

krhubert · 2019-11-25T18:41:06Z

closes #1526

sdk/process/msgs.go

sdk/process/backend.go

sdk/ownership/backend.go

sdk/process/backend.go

process/codec.go

sdk/ownership/backend.go

NicolasMahe · 2019-12-02T09:28:27Z

Let's wait for issue #1427 to be closed before merging this PR

# Conflicts: # protobuf/api/process.pb.go # protobuf/api/process.proto # server/grpc/api/process.go

NicolasMahe

TODO:

add e2e test on process ownership
- check its creation
- check its deletion

… service e2e test

antho1404

We need to fix this part

engine/sdk/execution/backend.go

Lines 95 to 100 in dd53368

    
           // TODO: to re-implement when process is on cosmos 
        
           // if !msg.Request.ProcessHash.IsZero() { 
        
           // 	if _, err := s.processSDK.Get(msg.Request.ProcessHash); err != nil { 
        
           // 		return nil, err 
        
           // 	} 
        
           // }

Except that and one small comment not blocking it's good

sdk/process/backend.go

…engine into feature/process-backend

NicolasMahe reviewed Nov 27, 2019

View reviewed changes

sdk/process/msgs.go Outdated Show resolved Hide resolved

krhubert force-pushed the feature/process-backend branch 3 times, most recently from 7572fc0 to a11b919 Compare November 27, 2019 16:21

NicolasMahe requested changes Nov 28, 2019

View reviewed changes

sdk/process/backend.go Outdated Show resolved Hide resolved

sdk/ownership/backend.go Outdated Show resolved Hide resolved

sdk/process/backend.go Show resolved Hide resolved

NicolasMahe reviewed Nov 28, 2019

View reviewed changes

process/codec.go Show resolved Hide resolved

krhubert added 2 commits November 28, 2019 10:32

Change ownership type layout

8865dc1

Move process sdk to cosmos network

9e3ef68

krhubert force-pushed the feature/process-backend branch from fcc987a to 5250592 Compare November 28, 2019 09:32

krhubert added breaking change enhancement New feature or request labels Nov 28, 2019

krhubert self-assigned this Nov 28, 2019

krhubert removed the breaking change label Nov 28, 2019

krhubert added this to the next milestone Nov 28, 2019

Refactor code + fix panics

5b4bf74

krhubert force-pushed the feature/process-backend branch from 5250592 to 5b4bf74 Compare November 28, 2019 09:36

krhubert marked this pull request as ready for review November 28, 2019 09:36

Use ownership.Create and remove CreateServiceOwnership

0d535fb

krhubert force-pushed the feature/process-backend branch from 177c11a to 0d535fb Compare November 28, 2019 10:16

NicolasMahe reviewed Nov 28, 2019

View reviewed changes

sdk/ownership/backend.go Outdated Show resolved Hide resolved

sdk/ownership/backend.go Outdated Show resolved Hide resolved

Replace usage of const in ownership backend

d7226dc

NicolasMahe mentioned this pull request Nov 28, 2019

Split execution to execution request and result #1533

Closed

NicolasMahe requested changes Nov 29, 2019

View reviewed changes

sdk/ownership/backend.go Outdated Show resolved Hide resolved

Replace store for index resources with many to many realation

76b010d

krhubert requested a review from NicolasMahe November 29, 2019 17:15

NicolasMahe reviewed Dec 2, 2019

View reviewed changes

sdk/ownership/backend.go Show resolved Hide resolved

NicolasMahe requested a review from antho1404 December 2, 2019 09:24

NicolasMahe added the on-hold label Dec 2, 2019

Use owner when delete ownerships

71cb4cd

NicolasMahe removed the on-hold label Dec 4, 2019

NicolasMahe added 2 commits December 4, 2019 18:02

Merge branch 'dev' into feature/process-backend

fcd16a0

# Conflicts: # protobuf/api/process.pb.go # protobuf/api/process.proto # server/grpc/api/process.go

fix merge

7629733

NicolasMahe reviewed Dec 4, 2019

View reviewed changes

add process ownership e2e test and move service ownership e2e test to…

5c52e09

… service e2e test

NicolasMahe approved these changes Dec 4, 2019

View reviewed changes

antho1404 requested changes Dec 5, 2019

View reviewed changes

sdk/process/backend.go Show resolved Hide resolved

krhubert added 2 commits December 5, 2019 22:22

Check msg.Request.ProcessHash on backend

821355a

Merge branch 'feature/process-backend' of github.com:mesg-foundation/…

80d5f03

…engine into feature/process-backend

krhubert requested a review from antho1404 December 5, 2019 21:22

antho1404 approved these changes Dec 11, 2019

View reviewed changes

antho1404 merged commit 93479e8 into dev Dec 11, 2019

antho1404 deleted the feature/process-backend branch December 11, 2019 07:41

NicolasMahe mentioned this pull request Dec 13, 2019

Update ownership proto mesg-foundation/js-sdk#151

Merged

1 task

NicolasMahe changed the title ~~Move process to cosmos network~~ Implement process on cosmos sdk Dec 13, 2019

NicolasMahe changed the title ~~Implement process on cosmos sdk~~ Decentralization of the processes Dec 13, 2019

NicolasMahe added the release:change Pull requests that change something existant label Dec 13, 2019

NicolasMahe mentioned this pull request Dec 26, 2019

Release v0.18.0 #1577

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decentralization of the processes #1527

Decentralization of the processes #1527

krhubert commented Nov 25, 2019 •

edited by NicolasMahe

Loading

NicolasMahe commented Dec 2, 2019

NicolasMahe left a comment •

edited

Loading

antho1404 left a comment

	// TODO: to re-implement when process is on cosmos
	// if !msg.Request.ProcessHash.IsZero() {
	// if _, err := s.processSDK.Get(msg.Request.ProcessHash); err != nil {
	// return nil, err
	// }
	// }

Decentralization of the processes #1527

Decentralization of the processes #1527

Conversation

krhubert commented Nov 25, 2019 • edited by NicolasMahe Loading

NicolasMahe commented Dec 2, 2019

NicolasMahe left a comment • edited Loading

Choose a reason for hiding this comment

antho1404 left a comment

Choose a reason for hiding this comment

krhubert commented Nov 25, 2019 •

edited by NicolasMahe

Loading

NicolasMahe left a comment •

edited

Loading