Customize cosmos address prefix #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
feature/addr-prefix
branch
from
250d601
to
5f41500
Compare
|
2nd time the e2e test fails, that's something suspicious about that ... not sure why |
Merged
|
Please have a look at this PR #1575. It should fix the issue. |
antho1404
approved these changes
Dec 30, 2019
antho1404
reviewed
Dec 30, 2019
antho1404
reviewed
Dec 30, 2019
NicolasMahe
added
the
release:change
NicolasMahe
changed the title
NicolasMahe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1571
Modified address for cosmos config (see: https://github.com/cosmos/cosmos-sdk/blob/master//types/address.go#L18-L69)
Also, we should reserve a code for mesg tokens according to https://github.com/satoshilabs/slips/blob/master/slip-0044.md