Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution metrics #1580

Merged
merged 6 commits into from
Jan 13, 2020
Merged

Add execution metrics #1580

merged 6 commits into from
Jan 13, 2020

Conversation

antho1404
Copy link
Member

@antho1404 antho1404 commented Jan 3, 2020

I needed to add some stats in order to debug #1570.

This is not a final version, let's discuss first what and how we need to implements metrics but this is a way to start.

To test

Start prometheus and grafana

docker service create -p 3001:3000 --network=engine grafana/grafana
docker service create -p 9090:9090 --network=engine --name=prometheus --mount type=bind,source=$(pwd)/prometheus.yml,destination=/etc/prometheus/prometheus.yml prom/prometheus

Configure grafana

  • go to http://localhost:3001/
  • add a datasource with the url http://prometheus:9090
  • create a dashboard with 4 different metrics
    • mesg_execution_created
    • mesg_execution_signed
    • mesg_execution_in_progress
    • mesg_execution_completed

Then you can create an execution the way you want and you will see the 4 different steps of the lifecycle of an execution


Prometheus config > https://github.com/mesg-foundation/engine/blob/f54c8633e59268bdb72af4b3f5501b11418e1d5f/prometheus.yml

@antho1404 antho1404 self-assigned this Jan 3, 2020
prometheus.yml Outdated Show resolved Hide resolved
server/grpc/server.go Show resolved Hide resolved
sdk/execution/metrics.go Show resolved Hide resolved
@NicolasMahe NicolasMahe added this to the next milestone Jan 10, 2020
@NicolasMahe NicolasMahe merged commit 6d279c5 into dev Jan 13, 2020
@NicolasMahe NicolasMahe deleted the feature/prometheus-stats branch January 13, 2020 03:51
@NicolasMahe NicolasMahe added the release:add Pull requests that add something label Jan 14, 2020
@NicolasMahe NicolasMahe changed the title Engine execution stats Add execution metrics Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal release:add Pull requests that add something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants