Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganise monitoring configs and add default dashboards #1636

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Reorganise monitoring configs and add default dashboards #1636

merged 1 commit into from
Feb 4, 2020

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Feb 4, 2020 •
edited
Loading

Continuation of #1632

  • Reorganise monitoring configs. Move configs file to scripts/monitoring.
  • Add 2 default dashboards.
    • i added https://github.com/zhangyelong/cosmos-dashboard
    • i also added another one for execution monitoring. this dashboard will need some update (see next point on how to save updates)
    • The default dashboard can be updated in grafana but you will get an error when saving them. If you want to persist the modification, update the dashboard source files in scripts/monitoring/dashboards.

closes #1570

@NicolasMahe NicolasMahe self-assigned this Feb 4, 2020
@NicolasMahe NicolasMahe mentioned this pull request Feb 4, 2020
Closed
@NicolasMahe NicolasMahe merged commit 4a64a43 into dev Feb 4, 2020
@NicolasMahe NicolasMahe deleted the feature/monitoring-dashboard branch February 4, 2020 11:04
@NicolasMahe NicolasMahe added this to the next milestone Feb 5, 2020
@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert approved these changes

@antho1404 antho1404 Awaiting requested review from antho1404

Assignees

@NicolasMahe NicolasMahe

Labels
release:change Pull requests that change something existant
Projects
None yet
Milestone
v0.18.3
Development

Successfully merging this pull request may close these issues.

Benchmark/performances for the executions
2 participants
@NicolasMahe @krhubert