Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to cosmos v0.38 and tendermint v0.33 #1640

Merged
merged 7 commits into from
Feb 6, 2020
Merged

Update to cosmos v0.38 and tendermint v0.33 #1640

merged 7 commits into from
Feb 6, 2020

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Feb 4, 2020 •
edited
Loading

Update to cosmos v0.38 🎊

but we had to set an hack (fae99d6) to force the sequence to increment even in when tx is being checked

closes #1612

@krhubert krhubert force-pushed the dependencies/cosmos-v0.38 branch 3 times, most recently from ae1b6f7 to ef4e274 Compare February 4, 2020 16:59
@krhubert
Copy link
Contributor

krhubert commented Feb 4, 2020

Needs test a bit more, but it will be done tommorow. Otherwise looking good.

@NicolasMahe NicolasMahe linked an issue Feb 5, 2020 that may be closed by this pull request
Cosmosization of the codebase #1639
Closed
3 tasks
@NicolasMahe NicolasMahe removed a link to an issue Feb 5, 2020
Cosmosization of the codebase #1639
Closed
3 tasks
NicolasMahe
NicolasMahe commented Feb 5, 2020
View reviewed changes
Copy link
Member Author

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why the e2e tests fail?
they are failing on the multiple execution in parallel test. maybe an issue with the sign function?

cosmos/errors.go Outdated Show resolved Hide resolved
cosmos/errors.go Show resolved Hide resolved
@NicolasMahe NicolasMahe mentioned this pull request Feb 6, 2020
Merged
1 task
@NicolasMahe
Add new decorator to force context.IsChectTx to false in NewIncrement…
fae99d6 
…SequenceDecorator to allow multiple tx from same account in one block
@NicolasMahe
Merge branch dev into dependencies/cosmos-v0.38
176bc83 
# Conflicts:
#	go.mod
#	go.sum
@NicolasMahe NicolasMahe marked this pull request as ready for review February 6, 2020 11:29
@krhubert krhubert merged commit 3f1f02f into dev Feb 6, 2020
@krhubert krhubert deleted the dependencies/cosmos-v0.38 branch February 6, 2020 14:12
@NicolasMahe NicolasMahe added this to the v0.19.0 milestone Mar 2, 2020
@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label Mar 2, 2020
@NicolasMahe NicolasMahe changed the title Update to cosmos v0.38 Update to cosmos v0.38 and tendermint v0.33 Mar 2, 2020
@NicolasMahe NicolasMahe mentioned this pull request Mar 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert approved these changes

Assignees
No one assigned
Labels
release:change Pull requests that change something existant
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.

Update to cosmos-sdk v0.38
2 participants
@NicolasMahe @krhubert