Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ownership module to cosmos style #1651

Merged
merged 5 commits into from
Feb 12, 2020
Merged

Refactor ownership module to cosmos style #1651

merged 5 commits into from
Feb 12, 2020

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Feb 10, 2020 •
edited by NicolasMahe
Loading

Unfortunately, I stuck on the problem with process deletion and I can't track it :/

@ NicolasMahe can you take a look (e2e tests)?

related to #1639

@krhubert krhubert added this to the next milestone Feb 10, 2020
@krhubert krhubert self-assigned this Feb 10, 2020
@krhubert krhubert force-pushed the refactor/cosmos-ownership-module branch 3 times, most recently from ad0f5ce to a0689a6 Compare February 10, 2020 18:51
@krhubert krhubert force-pushed the refactor/cosmos-ownership-module branch from a0689a6 to 4c57245 Compare February 10, 2020 18:55
@krhubert krhubert force-pushed the refactor/cosmos-ownership-module branch from 4c57245 to 10a69ef Compare February 10, 2020 18:59
NicolasMahe
NicolasMahe reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation, few stuff to change and few others that are not mandatory but nice to do 👍

app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
sdk/process/keeper.go Show resolved Hide resolved
sdk/process/keeper.go Show resolved Hide resolved
x/ownership/client/cli/query.go Outdated Show resolved Hide resolved
x/ownership/client/rest/query.go Show resolved Hide resolved
x/ownership/internal/keeper/keeper.go Show resolved Hide resolved
x/ownership/internal/types/key.go Show resolved Hide resolved
server/grpc/api/ownership.go Outdated Show resolved Hide resolved
@NicolasMahe
Copy link
Member

Unfortunately, I stuck on the problem with process deletion and I can't track it :/

@ NicolasMahe can you take a look (e2e tests)?

Found the issue. See https://github.com/mesg-foundation/engine/pull/1651/files#r377441190

@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label Feb 11, 2020
@NicolasMahe NicolasMahe mentioned this pull request Feb 11, 2020
Closed
3 tasks
@NicolasMahe NicolasMahe marked this pull request as ready for review February 11, 2020 10:35
NicolasMahe
NicolasMahe requested changes Feb 11, 2020
View reviewed changes
x/ownership/client/rest/query.go Outdated Show resolved Hide resolved
x/ownership/client/rest/query.go Outdated Show resolved Hide resolved
@krhubert krhubert force-pushed the refactor/cosmos-ownership-module branch from 03a506f to adea005 Compare February 11, 2020 11:17
@krhubert krhubert mentioned this pull request Feb 11, 2020
Merged
@NicolasMahe NicolasMahe merged commit 8643b6e into dev Feb 12, 2020
@NicolasMahe NicolasMahe deleted the refactor/cosmos-ownership-module branch February 12, 2020 03:01
@NicolasMahe NicolasMahe mentioned this pull request Feb 12, 2020
Merged
@NicolasMahe NicolasMahe added release:add Pull requests that add something and removed release:change Pull requests that change something existant labels Feb 12, 2020
@NicolasMahe NicolasMahe changed the title Use template to move ownership cosmos module to x/ dir Refactor ownership module to cosmos style Mar 2, 2020
@NicolasMahe NicolasMahe added release:change Pull requests that change something existant and removed release:add Pull requests that add something labels Mar 2, 2020
@NicolasMahe NicolasMahe mentioned this pull request Mar 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 left review comments

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees

@krhubert krhubert

Labels
refactoring release:change Pull requests that change something existant
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@krhubert @NicolasMahe @antho1404