Add address to process #1723
Merged
Add address to process #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
antho1404
force-pushed
the
feature/process-address
branch
from
d5a0262
to
c889ca6
Compare
antho1404
force-pushed
the
feature/process-address
branch
from
3ae4d18
to
e4ae1c0
Compare
NicolasMahe
approved these changes
Mar 13, 2020
# Conflicts: # e2e/process_test.go
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to add the address format to the process in order to be able to send token to this process.
Few ways this can be improved:
hash#marshalJSONwe could return the address instead of the base58This is a quick fix in order to fix the issue with the executions that collect coin from the process (#1699) but will need to be improved with #1715