Changelog and versions #174
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #174 +/- ##
==========================================
+ Coverage 69.25% 69.28% +0.02%
==========================================
Files 52 52
Lines 1070 1071 +1
==========================================
+ Hits 741 742 +1
Misses 260 260
Partials 69 69
Continue to review full report at Codecov.
|
.circleci/config.yml
Outdated
| - checkout | ||
| - run: docker pull mesg/daemon:latest | ||
| - run: docker build -t mesg/daemon:$CIRCLE_SHA1 . | ||
| - run: docker build -t mesg/daemon:local . |
There was a problem hiding this comment.
The 2 docker build steps could be merge like:
docker build -t mesg/daemon:$CIRCLE_SHA1 -t mesg/daemon:local .
Source: moby/moby#15780
There was a problem hiding this comment.
actually we don't really need the mesg/daemon:local
.circleci/config.yml
Outdated
| - run: docker build -t mesg/daemon:$CIRCLE_TAG . | ||
| - run: docker push mesg/daemon:$CIRCLE_TAG | ||
|
|
||
| "publish_docker_latest": |
There was a problem hiding this comment.
publish_docker_version and publish_docker_latest could be merge into a single task, no?
There was a problem hiding this comment.
I updated the workflow with
docker build -> test -> publish tag && publish latest in parallel -> release cli
Like that we can parallelize the 2 push of the docker images
.circleci/config.yml
Outdated
| <<: *runOnMachine | ||
| steps: | ||
| - checkout | ||
| - run: docker login -u $DOCKER_USER -p $DOCKER_PASS |
There was a problem hiding this comment.
Why not add the docker pull mesg/daemon:latest here? It's used in the task build_docker
There was a problem hiding this comment.
at this step it should be in the cache of the machine but just in case we can I it in case the cache doesn't really work
CHANGELOG.md
Outdated
| ## [Unreleased] | ||
|
|
||
| #### Changed | ||
| - (#174) Update CI to build verion based on tags |
fix #166