Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set grace period to 1m in dev script #1760

Merged
merged 3 commits into from
May 2, 2020
Merged

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Mar 28, 2020

Set grace period to 1m in dev script to give enough time to the engine to stop running services and stop gracefully.
The default in docker is only 10sec.

closes #1634

The engine's log should output all on this when stopping:

INFO[0022] stopping running services                     module=main
INFO[0022] ABCIQuery                                     data= module=rpc path=custom/runner/list result="value:\"null\" height:77 "
INFO[0022] cleanup container                             module=main
INFO[0022] stopping lcd server                           module=main
INFO[0022] RPC HTTP server stopped                       err="accept tcp [::]:1317: use of closed network connection"
WARN[0022] accept tcp [::]:1317: use of closed network connection  module=main
INFO[0022] stopping orchestrator                         module=main
INFO[0022] stopping grpc server                          module=main
INFO[0022] stopping tendermint                           module=main
INFO[0022] Stopping Node                                 impl=Node
INFO[0022] Stopping Node
INFO[0022] Stopping EventBus                             impl=EventBus module=events
INFO[0022] Stopping PubSub                               impl=PubSub module=pubsub
INFO[0022] Stopping IndexerService                       impl=IndexerService module=txindex
INFO[0022] Stopping P2P Switch                           impl="P2P Switch" module=p2p
INFO[0022] Stopping Reactor                              impl=Reactor module=mempool
INFO[0022] Stopping BlockchainReactor                    impl=BlockchainReactor module=blockchain
ERRO[0022] Not stopping BlockPool -- have not been started yet  impl=BlockPool module=blockchain
INFO[0022] Stopping Reactor                              impl=ConsensusReactor module=consensus
INFO[0022] Stopping State                                impl=ConsensusState module=consensus
INFO[0022] Stopping TimeoutTicker                        impl=TimeoutTicker module=consensus
INFO[0022] Stopping baseWAL                              impl=baseWAL module=consensus wal=/root/.mesg/tendermint/data/cs.wal/wal
INFO[0022] Stopping Group                                impl=Group module=consensus wal=/root/.mesg/tendermint/data/cs.wal/wal
INFO[0022] Stopping Reactor                              impl=Reactor module=evidence
INFO[0022] Stopping Reactor                              impl=Reactor module=pex
INFO[0022] Stopping AddrBook                             book=/root/.mesg/tendermint/config/addrbook.json impl=AddrBook module=p2p
INFO[0022] Closing rpc listener                          listener="&{0xc00009c060 0xc000083140 {0 {0 0}} 0xc0000831a0}"
INFO[0022] RPC HTTP server stopped                       err="accept tcp [::]:26657: use of closed network connection" module=rpc-server

if those logs don't show up, the engine has been killed and the databases might be corrupted (happen sometime when syncing with the network)

@NicolasMahe NicolasMahe added the release:fix Pull requests that fix something label Mar 28, 2020
@NicolasMahe NicolasMahe added this to the next milestone Mar 28, 2020
@NicolasMahe NicolasMahe self-assigned this Mar 28, 2020
@NicolasMahe NicolasMahe modified the milestones: v0.21.0, next Apr 19, 2020
@NicolasMahe NicolasMahe merged commit 4352b2b into dev May 2, 2020
@NicolasMahe NicolasMahe deleted the feature/graceful-stop branch May 2, 2020 08:06
@NicolasMahe NicolasMahe mentioned this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix Pull requests that fix something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set StopGracePeriod when creating the engine docker service in dev script
1 participant