Add modules gov, upgrade, evidence and crisis #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
reviewed
Jun 3, 2020
| @@ -230,6 +251,48 @@ func NewInitApp( | |||
| app.subspaces[slashing.ModuleName], | |||
| ) | |||
|
|
|||
| app.crisisKeeper = crisis.NewKeeper( | |||
There was a problem hiding this comment.
This is useless if there is no route associated. Can be added later anyway, when/if we need to use the module.
| ) | ||
| // During begin block slashing happens after distr.BeginBlocker so that | ||
| // there is nothing left over in the validator fee pool, so as to keep the | ||
| // CanWithdrawInvariant invariant. | ||
|
|
||
| app.mm.SetOrderBeginBlockers(distr.ModuleName, slashing.ModuleName) | ||
| app.mm.SetOrderEndBlockers(staking.ModuleName) | ||
| app.mm.SetOrderBeginBlockers(upgrade.ModuleName, distr.ModuleName, slashing.ModuleName) |
There was a problem hiding this comment.
Evidence should be here as it validates the double sign at each begin block.
There was a problem hiding this comment.
Wait for confirmation on an issue with cosmos team cosmos/scaffold#80
# Conflicts: # app/app.go
antho1404
approved these changes
Jun 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1854
Add modules gov, upgrade, evidence and crisis