Stop services when the daemon stops #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #187 +/- ##
=========================================
+ Coverage 74.2% 74.58% +0.38%
=========================================
Files 57 57
Lines 1159 1157 -2
=========================================
+ Hits 860 863 +3
+ Misses 229 226 -3
+ Partials 70 68 -2
Continue to review full report at Codecov.
|
…-services-when-daemon-stop # Conflicts: # CHANGELOG.md # cmd/daemon/stop.go # examples/services/test-event # service/hash_test.go # service/start.go
NicolasMahe
requested changes
Jun 5, 2018
cmd/daemon/stop.go
Outdated
| } | ||
| for _, hash := range hashes { | ||
| // TODO: this function should be execute in a go routine. StopService is blocking | ||
| _, err := cli.StopService(context.Background(), &core.StopServiceRequest{ |
There was a problem hiding this comment.
This should be called in a async fashion to stop all services at the same time.
|
I updated |
NicolasMahe
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I added a new label for docker services
mesg.hashWith this label, we can now from a docker service retrieve the service in the database and do whatever we want. In this case just before stoping the daemon we can stop all the running services
fix #158