Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service: update error types to be more logicless, simplify validations #402

Merged
merged 11 commits into from
Aug 29, 2018

Commits on Aug 28, 2018

  1. service: update error types to make them more logicless, simplify val…

    …idations. closes #350, related with #348, a part of #337
    
    * error types now doesn't call methods from its struct fields for validation.
    * remove isValid and Validate methods from types and adapt generic service.ValidateParametersSchema() method.
    * TestValidParameters removed from service package. no longer needed.
    ilgooz committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    6765127 View commit details
    Browse the repository at this point in the history
  2. errors defined in service pkg: move not found and invalid data relate…

    …d error checking logic to parent caller
    
    * TestCreateNotPresentEvent removed from event package, it has an equivalent TestEmitWrongEvent in interface/grpc/service.
    * TestCreateInvalidData removed from event package, an equivalent TestEmitInvalidData added to interface/grpc/service.
    * TestCreateInvalidTask removed from execution package, it has an equivalent TestExecuteWithInvalidTask in interface/grpc/core.
    * TestCompleteNotFound removed from execution package, an equivalent TestSubmitWithNonExistentOutputKey added to interface/grpc/service.
    * TestCreateInvalidInputs removed from execution package, an equivalent TestExecuteWithInvalidTaskInput added to interface/grpc/core.
    * TestCompleteInvalidOutputs removed from execution package, an equivalent TestSubmitWithInvalidTaskOutputs added to interface/grpc/service.
    ilgooz committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    fdff627 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2edf0d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5bf034b View commit details
    Browse the repository at this point in the history
  5. fix typo on parameter

    antho1404 committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    dee3e73 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2018

  1. errors defined in service pkg: undo moving error checking logic to pa…

    …rent caller, re-add removed tests
    ilgooz committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    5ea7383 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    565e17a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    774ce02 View commit details
    Browse the repository at this point in the history
  4. fix .circleci

    ilgooz committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    c0ddee8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ca90f8d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8645863 View commit details
    Browse the repository at this point in the history