service: add unit tests #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
force-pushed
the
feature/service-unit-tests
branch
from
661dad8
to
9fc91dc
Compare
antho1404
requested changes
Sep 16, 2018
|
Is it still WIP? |
|
@NicolasMahe I was evaluating for all techniques for unit testing after @krhubert suggestion with testify/mock. The original idea was to experiment with dockertest for service and api packages too and bring some knowledge from unit testing of go-service and go-application onto table and give a final decision about refactoring dockertest. But I think, I'll go with completing unit tests of service package today and give my decision about which mocking/faking techniques we should go with for core. |
ilgooz
force-pushed
the
feature/service-unit-tests
branch
from
bd70192
to
98014f0
Compare
|
conflicts are resolved |
antho1404
approved these changes
Sep 24, 2018
NicolasMahe
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR enables integration tests with build flags and and covers some of the unit tests for service package