Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker from core #470

Closed
wants to merge 14 commits into from
Closed

Remove docker from core #470

wants to merge 14 commits into from

Conversation

krhubert
Copy link
Contributor

No description provided.

@antho1404
Copy link
Member

services are not working, certainly due to the fact that we are using a docker network for that with the mesg-core name.

service          | events.js:167
service          |       throw er; // Unhandled 'error' event
service          |       ^
service          |
service          | Error: 14 UNAVAILABLE: Name resolution failure
service          |     at Object.exports.createStatusError (/app/node_modules/grpc/src/common.js:87:15)
service          |     at ClientReadableStream._emitStatusIfDone (/app/node_modules/grpc/src/client.js:235:26)
service          |     at Object.onReceiveStatus (/app/node_modules/grpc/src/client_interceptors.js:1256:15    at Object.onReceiveStatus (/app/node_modules/grpc/src/client_interceptors.js:1256:15)
service          |     at InterceptingListener._callNext (/app/node_modules/grpc/src/client_interceptors.js:564:42)
service          |     at InterceptingListener.onReceiveStatus (/app/node_modules/grpc/src/client_interceptors.js:614:8)

@krhubert
Copy link
Contributor Author

@antho1404 Is it only related to js?

➜  core git:(feature/remove-docker) go run main.go service dev ../../krhubert/mesg-test
✔ Service deployed
✔ Service started with success: 44304291d56c60ca24961e139de816bb7bb25b09
service | {"level":"info","msg":"","time":"2018-09-17T15:29:14Z","version":"v0.0.0"}
service | {"level":"info","msg":"connecting to mesg endpoint mesg-core:50052","time":"2018-09-17T15:29:14Z"}

certainly due to the fact that we are using a docker network for that with the mesg-core name.

Don't get this, need to check this.

@mesg-bot
Copy link
Member

This pull request has been mentioned on MESG. There might be relevant details there:

https://forum.mesg.com/t/trustful-network/35/1

@antho1404
Copy link
Member

Updated the root command because some stuff were removed and the server didn't shut down correctly (https://github.com/mesg-foundation/core/blob/bf15f80105e8c1b212098ba7de5175a8c584989f/core/main.go#L27-L34)

Also added the closing of the database all this using the defer

@mesg-bot
Copy link
Member

This pull request has been mentioned on MESG Community. There might be relevant details there:

https://forum.mesg.com/t/newable-database/45/1

@krhubert
Copy link
Contributor Author

Closing in favor of #478

@krhubert krhubert closed this Sep 20, 2018
@antho1404
Copy link
Member

Still this one is interesting for the database refactoring. It could be good to extract this part in a new PR.

@mesg-bot
Copy link
Member

This pull request has been mentioned on MESG Community. There might be relevant details there:

https://forum.mesg.com/t/integrating-the-forum-in-github/53/2

@antho1404 antho1404 deleted the feature/remove-docker branch September 29, 2018 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants