service hash changes for every deploy (when fetching from git) #close 379 #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
reviewed
Sep 20, 2018
|
|
||
| // XXX: remove .git folder from repo. | ||
| // It makes docker build iamge id same between repo clones. | ||
| if err := os.RemoveAll(filepath.Join(path, ".git")); err != nil { |
There was a problem hiding this comment.
maybe we can have a slice const at the top to specify folders that needs to be deleted for different version control systems.
There was a problem hiding this comment.
We only support git right now, discussion about different system etc should be continued in another issue
|
For information, the problem really comes from git when git is creating the HEAD, it looks like it create it based on the time of the clone. We could maybe delete the HEAD or something like that but deleting the git is totally fine. |
antho1404
approved these changes
Sep 20, 2018
NicolasMahe
approved these changes
Sep 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #379