Add multiline option to Pretty.ColorizeJSON #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
antho1404
previously approved these changes
Sep 20, 2018
krhubert
reviewed
Sep 20, 2018
utils/pretty/pretty.go
Outdated
| if p.noColor { | ||
| return data | ||
| } | ||
|
|
||
| f := prettyjson.NewFormatter() | ||
| f.Indent = 0 | ||
| f.Newline = "" | ||
| if multiline == false { |
There was a problem hiding this comment.
Updated but I really don't like !. It's too small. I prefer explicit false
There was a problem hiding this comment.
It's go way:
➜ a git:(dev) ✗ gometalinter .
main.go:7:5:warning: should omit comparison to bool constant, can be simplified to !a (S1002) (megacheck)
Also go source code:
➜ src gogrep 'if !' |wc -l
8661
➜ src gogrep 'if.*== false' |wc -l
17
➜ src
There was a problem hiding this comment.
I don't like the false == multiline it's more "conventional but we never do that anywhere in the code. I think it's better to have consistency. Or if you want just change the parameter with inline like that you have a if inline ;)
There was a problem hiding this comment.
Ok guys, I give up on this ;)
antho1404
approved these changes
Sep 21, 2018
ilgooz
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple PR to add the multiline option to Pretty.ColorizeJSON function.
It is useful for a following PR.