Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: simplify file structure #488

Merged
merged 4 commits into from
Sep 21, 2018
Merged

api: simplify file structure #488

merged 4 commits into from
Sep 21, 2018

Conversation

ilgooz
Copy link
Contributor

@ilgooz ilgooz commented Sep 20, 2018 •
edited
Loading

closes #442

@ilgooz ilgooz requested review from antho1404, NicolasMahe and krhubert and removed request for antho1404 September 20, 2018 15:27
antho1404
antho1404 previously approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why increasing the buffers for dockertest? especially in this PR?

Also later we can later simplify even more to remove the intermediary object

@ilgooz
Copy link
Contributor Author

ilgooz commented Sep 21, 2018 •
edited
Loading

@antho1404 I saw a test broken on CI, for this PR because of the small buf size of dockertest chans. It was actually a fix.

@ilgooz
Copy link
Contributor Author

ilgooz commented Sep 21, 2018

good to review

antho1404
antho1404 previously approved these changes Sep 21, 2018
View reviewed changes
NicolasMahe
NicolasMahe previously approved these changes Sep 21, 2018
View reviewed changes
@NicolasMahe
Copy link
Member

@ilgooz can you fix the conflict please?

@ilgooz ilgooz dismissed stale reviews from NicolasMahe and antho1404 via 017025c September 21, 2018 09:54
@ilgooz
Copy link
Contributor Author

ilgooz commented Sep 21, 2018

good to review

@NicolasMahe NicolasMahe merged commit 3dbd069 into dev Sep 21, 2018
@NicolasMahe NicolasMahe deleted the feature/simplfy-api branch September 21, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@krhubert krhubert Awaiting requested review from krhubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine feature files into one
3 participants
@ilgooz @NicolasMahe @antho1404