Remove warning about .mesgingnore close #494 #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
requested changes
Sep 26, 2018
There was a problem hiding this comment.
It doesn't work.
The .mesgignore doesn't do anything which is totally fine but the the .dockerignore is ignored too and this is not good, try to create a service and put a dockerignore that ignore all the files and the service will start correctly anyway.
./dev-cli service init --dir=test
echo "index.js" >> test/.dockerignore
./dev-cli service dev test
We should do some real manual testing all the time to make sure that the feature is actually really working.
|
Done, sorry for that! |
ilgooz
approved these changes
Sep 26, 2018
antho1404
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #494