Improve hack on StopService function to force removing the container #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
changed the title
ilgooz
reviewed
Oct 5, 2018
| return err | ||
| } | ||
| c.client.ContainerStop(ctx, container.ID, &timeout) | ||
| c.client.ContainerRemove(ctx, container.ID, types.ContainerRemoveOptions{}) |
There was a problem hiding this comment.
I think, we should enable Force option within ContainerRemoveOptions in case container is not properly stopped. What do you think?
There was a problem hiding this comment.
The force option is quite risky... because we don't know the kind of services that are running I would definitely avoid this solution as much as possible. This might corrupt the service.
There was a problem hiding this comment.
The timeout parameter in the containerStop function allow the container to stop gracefully before being killed.
So we already have this mechanism.
ilgooz
approved these changes
Oct 5, 2018
antho1404
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge