Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make daemon newable #580

Merged
merged 9 commits into from
Nov 29, 2018
Merged

Make daemon newable #580

merged 9 commits into from
Nov 29, 2018

Conversation

krhubert
Copy link
Contributor

No description provided.

ilgooz
ilgooz reviewed Nov 22, 2018
View reviewed changes
container/service_test.go Show resolved Hide resolved
container/service_test.go Show resolved Hide resolved
container/service.go Show resolved Hide resolved
container/service.go Show resolved Hide resolved
@krhubert krhubert mentioned this pull request Nov 27, 2018
Merged
NicolasMahe
NicolasMahe previously approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krhubert please resolve conflict

NicolasMahe
NicolasMahe previously approved these changes Nov 28, 2018
View reviewed changes
@ilgooz
Copy link
Contributor

ilgooz commented Nov 28, 2018 •
edited
Loading

Do we have manual tests done?

@krhubert
Copy link
Contributor Author

yes

@ilgooz
Copy link
Contributor

ilgooz commented Nov 28, 2018

/cc @antho1404 I remember that you wanted to do your own manual tests as well, in Discord.

ilgooz
ilgooz reviewed Nov 28, 2018
View reviewed changes
daemon/daemon_test.go Outdated Show resolved Hide resolved
ilgooz
ilgooz reviewed Nov 28, 2018
View reviewed changes
daemon/daemon_test.go Outdated Show resolved Hide resolved
ilgooz
ilgooz reviewed Nov 28, 2018
View reviewed changes
daemon/daemon_test.go Outdated Show resolved Hide resolved
ilgooz
ilgooz reviewed Nov 28, 2018
View reviewed changes
daemon/daemon_test.go Outdated Show resolved Hide resolved
ilgooz
ilgooz suggested changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs changes on tests

ilgooz
ilgooz suggested changes Nov 29, 2018
View reviewed changes
daemon/daemon_test.go Show resolved Hide resolved
daemon/daemon_test.go Show resolved Hide resolved
container/service_test.go Show resolved Hide resolved
container/service_test.go Show resolved Hide resolved
@ilgooz ilgooz merged commit cb387ac into dev Nov 29, 2018
@ilgooz ilgooz deleted the refactor/daemon-newable branch November 29, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@ilgooz ilgooz ilgooz approved these changes

@antho1404 antho1404 Awaiting requested review from antho1404

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krhubert @ilgooz @NicolasMahe