Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1 min keepalive in grpc #738

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Add 1 min keepalive in grpc #738

merged 2 commits into from
Jan 28, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Jan 28, 2019 •
edited by ilgooz
Loading

fixes #549

@ilgooz
Copy link
Contributor

ilgooz commented Jan 28, 2019

my tests are also good, it's working!

@ilgooz ilgooz mentioned this pull request Jan 28, 2019
Closed
@ilgooz ilgooz merged commit f5d74bc into dev Jan 28, 2019
@ilgooz ilgooz deleted the fix/server-keepalive branch January 28, 2019 11:09
@krhubert krhubert mentioned this pull request Jan 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interface/grpc/core: ListenTask gets canceled
3 participants
@krhubert @ilgooz @NicolasMahe