Stop services when core stop #790
Conversation
antho1404
requested review from
krhubert and
NicolasMahe
and removed request for
krhubert
|
not really necessary, services will anyway be stopped but that simplifies the cli for sure |
|
@mesg-foundation/core can you please review |
antho1404
force-pushed
the
feature/stop-services-on-core-stop
branch
from
0656331
to
acd03bb
Compare
| server, err := initGRPCServer(c) | ||
| if err != nil { | ||
| // init system services. | ||
| if err := deployCoreServices(dep.config, dep.api); err != nil { |
There was a problem hiding this comment.
I think it makes more sense to start the gRPC server before deploying the Core services:
The services will fail (and restart) until the gRPC server is up and running.
There was a problem hiding this comment.
just kept the same behavior here as before just refactors it but the behavior is the same.
I agree it's not perfect, optimal solution would be:
- deploy service
- start service api
- start deployed services
- start core api
But this is not the purpose of this PR
| if err != nil { | ||
| return err | ||
| } | ||
| for _, s := range services { |
There was a problem hiding this comment.
Could all the services be stop at the same time in parallel?
There was a problem hiding this comment.
It could I just wanted to make it simple for now. This can be done in another PR
Modif of https://github.com/mesg-foundation/core/pull/792/files are not in this PR anymore. Maybe because of a force push. |
antho1404
force-pushed
the
feature/stop-services-on-core-stop
branch
from
0926c24
to
220295e
Compare
|
modifications from #792 in the PR again. |
|
Manual tests are OK. I see a weird bug sometimes(we fixed this before), ethwallet service seems running but it's Docker service is actually not exists. I'll open an issue, if I can reproduce again. |
|
This pull request has been mentioned on MESG Community. There might be relevant details there: |
Right now we rely on the CLI to stop all service before stoping the core. This is not really nice and create issues if we stop the core with another CLI (
docker service rmfor exemple).When the Core stops, it will stop all the running services, close the api and then exit.