-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CLI from Core #791
Remove CLI from Core #791
Conversation
097fb19
to
f68cc15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manual tests are good!
@@ -78,18 +76,25 @@ if [[ ! $BINCACHED ]] || [[ ! $DOCKERCACHED ]]; then | |||
docker build -f Dockerfile.dev -t "mesg/core:$VERSION" . | |||
fi | |||
|
|||
./bin/cli stop | |||
# docker service rm core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgotten comment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is working well, but why when I ctrl+c the script ./dev-core, I get this error as last line of the output:
Error: No such service: core
Its the output of docker service rm core
but only if the core doesn't exist. It feels like it's being called 2 times but I cannot debug it
yes can't find how to fix that but can be done in another PR if needed and anyway it's working and just for dev so it's fine to keep it like that |
@krhubert please also review and test ;) |
Let's merge first #974 so we can have a last working CLI compatible with single-output until the js version is ready! |
There is a missing stuff in this PR:
|
Another PR to remove some scripts: #996 |
Remove circleci cli tasks
421e6b8
# Conflicts: # commands/commands.go # commands/mocks/Executor.go # commands/provider/client.go # commands/provider/marketplace_provider.go # commands/provider/service_provider.go # commands/provider/wallet_provider.go # commands/service_dev.go # commands/service_dev_test.go # commands/service_execute.go
Remove cli scripts
@mesg-foundation/core i will force merge this PR when test are green! |
I'm working on another CLI separated from the core and in JS here https://github.com/mesg-foundation/cli.
So we take this decision, all the files in this PR are not necessary anymore