Add command marketplace #817

NicolasMahe · 2019-03-15T11:26:29Z

Dependent on #810

Deployed at address 0x94F4cB92Fe9f547574Aec617B1594B13aBd47Ad3 with token address 0x5861B3DC52339d4f976B7fa5d80dB6cd6f477F1B.

Procedure to test:

Import account that has MESG token into wallet

./dev-cli wallet import

Deploy

Try to deploy a paid service

./dev-cli service deploy mesg://marketplace/service/6de8cf8fd74582eb46318058154f79c6ba4e04e83889399fc414adc89c880025

See error message

Purchase service

./dev-cli marketplace purchase com.mesg.bitcoin

Deploy again

./dev-cli service deploy mesg://marketplace/service/6de8cf8fd74582eb46318058154f79c6ba4e04e83889399fc414adc89c880025

Should work 🎊 🍾 (only for 3min because offer is only for 3min)

Publish a service on the marketplace

Publish

./dev-cli marketplace publish ./PATH_TO_SERVICE

Create offer

./dev-cli marketplace create-offer SID_OF_SERVICE

…etplace

…nction.

antho1404

In general really good, just put few feedback in comments and some additional here.

Seems like the go format is broken on the CI, I have few warning in the editor, missing comments, bad indentation... please go format again.

More related to the PR, I feel that the commands are not complete. We can publish informations on the marketplace but don't have the results from it. Knowing if the transaction is sent is one thing but knowing the result is another and knowing the index of the offer, the version of the service etc... is quite important.

Also my feeling is that there is a lot of logic in the CLI that should be moved into the marketplace system service (part of my comment about error handling on the marketplace too). The CLI should not have the responsibility to validate the author or things like that.

Nothing blocking for this PR but definitely some stuff to consider. Otherwise all good :)

antho1404 · 2019-03-19T12:15:37Z

commands/marketplace_create_offer.go

+		return err
+	}
+
+	if !strings.EqualFold(c.service.Owner, c.account) {


Fine but I think this check should be done by the system service marketplace, the CLI should just call the createOffer task without having to do any check on the data

antho1404 · 2019-03-19T12:19:53Z

commands/marketplace_create_offer.go

+	if err != nil {
+		return err
+	}
+	fmt.Printf("%s Offer created with success\n", pretty.SuccessSign)


If we have these commands in the CLI we need to display all relevant information. Here for example the index of the offer. Here I cannot from the CLI only do anything after that

Yes you are right. The complicated thing is the marketplace service is returning a generic transaction receipt. It is not properly decoded because it doesn't know which method / event has been called or triggered.
I will work on a solution, but this is not a blocking thing for this PR.

Not blocking for this PR for sure but one solution is to listen at the event from the marketplace.
That's the implementation i did for the js cli. Like that we have the confirmation with the receipt (but we don't care much) and we have the event with the relevant data from the event from the smart contract.

here is an example for this implementation based on event
feature/command-marketplace...feature/command-marketplace-with-listen

commands/marketplace_publish.go

commands/marketplace_purchase.go

commands/marketplace_root.go

commands/provider/provider.go

commands/provider/marketplace_provider.go

…ketplace provider

…. Improve marketplace commands example

NicolasMahe · 2019-03-20T12:44:40Z

Seems like the go format is broken on the CI, I have few warning in the editor, missing comments, bad indentation... please go format again.

I see that CodeClimate throw an gofmt error but when running it locally I don't get any error. Can you tell me what is it or directly fix it?

ilgooz

the code seems fine 👍 i'll finish my review after completing my manual tests

antho1404 · 2019-03-21T04:14:56Z

diff --git a/commands/provider/marketplace_provider.go b/commands/provider/marketplace_provider.go
index 0cf3bc30..61afba8c 100644
--- a/commands/provider/marketplace_provider.go
+++ b/commands/provider/marketplace_provider.go
@@ -25,9 +25,9 @@ func NewMarketplaceProvider(c coreapi.CoreClient) *MarketplaceProvider {
 func (p *MarketplaceProvider) PublishServiceVersion(sid, manifest, manifestProtocol, from string) (Transaction, error) {
        input := marketplacePublishServiceVersionTaskInputs{
                marketplaceTransactionTaskInputs: marketplaceTransactionTaskInputs{From: from},
-               Sid:                              sid,
-               Manifest:                         manifest,
-               ManifestProtocol:                 manifestProtocol,
+               Sid:              sid,
+               Manifest:         manifest,
+               ManifestProtocol: manifestProtocol,
        }
        var output Transaction
        return output, p.call("publishServiceVersion", input, &output)
@@ -37,9 +37,9 @@ func (p *MarketplaceProvider) PublishServiceVersion(sid, manifest, manifestProto
 func (p *MarketplaceProvider) CreateServiceOffer(sid string, price string, duration string, from string) (Transaction, error) {
        input := marketplaceCreateServiceOfferTaskInputs{
                marketplaceTransactionTaskInputs: marketplaceTransactionTaskInputs{From: from},
-               Sid:                              sid,
-               Price:                            price,
-               Duration:                         duration,
+               Sid:      sid,
+               Price:    price,
+               Duration: duration,
        }
        var output Transaction
        return output, p.call("createServiceOffer", input, &output)
@@ -49,8 +49,8 @@ func (p *MarketplaceProvider) CreateServiceOffer(sid string, price string, durat
 func (p *MarketplaceProvider) Purchase(sid, offerIndex, from string) ([]Transaction, error) {
        input := marketplacePurchaseTaskInputs{
                marketplaceTransactionTaskInputs: marketplaceTransactionTaskInputs{From: from},
-               Sid:                              sid,
-               OfferIndex:                       offerIndex,
+               Sid:        sid,
+               OfferIndex: offerIndex,
        }
        var output marketplacePurchaseTaskOutputs
        return output.Transactions, p.call("purchase", input, &output)

This fixes codeclimate but then triggers and error with the circle ci lint.
My vscode automatically format it without all the space but not sure what is the "right" way to do.

NicolasMahe · 2019-03-21T04:52:51Z

which version of go do you use?
mine is go 1.11.4

antho1404 · 2019-03-21T05:15:15Z

same here

antho1404

Good for me, let's just make sure the current comments are tracked and can be done in different PR.

Move some verification logic from the CLI to the service
Listen confirmation event from the service in the CLI to display results

ilgooz

really excited about finally having marketplace commands integrated. 🎊

manual tests are ok.

we definitely need to do some improvements like @antho1404 suggested, for example, moving logic out as much as possible from CLI but they can be done within another PRs. we need some user experience improvements as well, like:

error messages should be more user friendly.
we can have the --yes flag for approving service publish to skip terminal prompts.
publish command only supports deploying from path but it still is able to receive urls and there is no error for this. when a git url or tarball provided, publish process starts but gets broken after a while (while creating manifest)

antho1404 · 2019-03-24T14:11:18Z

Merging now, @NicolasMahe make sure to see all comments

NicolasMahe force-pushed the feature/command-marketplace branch from 1137d4b to a30d3cb Compare March 19, 2019 07:27

NicolasMahe added 2 commits March 19, 2019 14:32

Add command marketplace

fb456b0

Generate mocks

3ba7807

NicolasMahe force-pushed the feature/command-marketplace branch from a30d3cb to 3ba7807 Compare March 19, 2019 07:32

NicolasMahe added 4 commits March 19, 2019 14:44

Merge branch 'dev' into feature/command-marketplace

3549980

Merge branch 'ci/codeclimate-exclude-mocks' into feature/command-mark…

9fa5c02

…etplace

Fix merge

483c20e

Fix website url in command create offer. Remove unused sha3 helper fu…

a56eb0e

…nction.

NicolasMahe marked this pull request as ready for review March 19, 2019 11:17

NicolasMahe requested review from antho1404, krhubert and ilgooz March 19, 2019 11:18

antho1404 reviewed Mar 19, 2019

View reviewed changes

NicolasMahe added 7 commits March 20, 2019 18:32

Fix missing comment on public method

f80f289

Remove task DisableServiceOffer and TransferServiceOwnership from mar…

63da140

…ketplace provider

Rename flag offerIndex to offer-index in command marketplace purchase…

a3da26d

…. Improve marketplace commands example

Create marketplaceServiceHashVersion

659629a

Change marketplace command short text

c377038

Remove unused marketplace struct

f83d3f4

Merge branch 'dev' into feature/command-marketplace

bf4f214

ilgooz reviewed Mar 20, 2019

View reviewed changes

antho1404 force-pushed the feature/command-marketplace branch from eda56c1 to bf4f214 Compare March 21, 2019 04:12

antho1404 approved these changes Mar 21, 2019

View reviewed changes

ilgooz approved these changes Mar 22, 2019

View reviewed changes

antho1404 merged commit f07a946 into dev Mar 24, 2019

antho1404 deleted the feature/command-marketplace branch March 24, 2019 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add command marketplace #817

Add command marketplace #817

NicolasMahe commented Mar 15, 2019 •

edited

Loading

antho1404 left a comment •

edited

Loading

antho1404 Mar 19, 2019

antho1404 Mar 19, 2019

NicolasMahe Mar 20, 2019

antho1404 Mar 21, 2019

antho1404 Mar 21, 2019

NicolasMahe commented Mar 20, 2019

ilgooz left a comment •

edited

Loading

antho1404 commented Mar 21, 2019

NicolasMahe commented Mar 21, 2019

antho1404 commented Mar 21, 2019

antho1404 left a comment

ilgooz left a comment

antho1404 commented Mar 24, 2019

Add command marketplace #817

Add command marketplace #817

Conversation

NicolasMahe commented Mar 15, 2019 • edited Loading

Import account that has MESG token into wallet

Deploy

Try to deploy a paid service

Purchase service

Deploy again

Publish a service on the marketplace

Publish

Create offer

antho1404 left a comment • edited Loading

Choose a reason for hiding this comment

antho1404 Mar 19, 2019

Choose a reason for hiding this comment

antho1404 Mar 19, 2019

Choose a reason for hiding this comment

NicolasMahe Mar 20, 2019

Choose a reason for hiding this comment

antho1404 Mar 21, 2019

Choose a reason for hiding this comment

antho1404 Mar 21, 2019

Choose a reason for hiding this comment

NicolasMahe commented Mar 20, 2019

ilgooz left a comment • edited Loading

Choose a reason for hiding this comment

antho1404 commented Mar 21, 2019

NicolasMahe commented Mar 21, 2019

antho1404 commented Mar 21, 2019

antho1404 left a comment

Choose a reason for hiding this comment

ilgooz left a comment

Choose a reason for hiding this comment

antho1404 commented Mar 24, 2019

NicolasMahe commented Mar 15, 2019 •

edited

Loading

antho1404 left a comment •

edited

Loading

ilgooz left a comment •

edited

Loading