Improvements of commands service init and service gendoc #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
reviewed
Mar 18, 2019
ilgooz
reviewed
Mar 18, 2019
antho1404
reviewed
Mar 18, 2019
| PreRunE: c.preRunE, | ||
| RunE: c.runE, | ||
| }) | ||
| c.cmd.Flags().BoolVarP(&c.force, "force", "f", c.force, "No confirmation. Will replace existing README.md file") |
There was a problem hiding this comment.
I don't see the use of this flag in the command
There was a problem hiding this comment.
There was a problem hiding this comment.
The logic was already implemented but the flag was not exposed
There was a problem hiding this comment.
I think having force option is good for non interactive terminals. But we can change it to --yes because we use it in general, in other commands too. It exists for answering all terminal prompts as yes by default in a command action. But this improvement can be done in an another PR.
krhubert
approved these changes
Mar 19, 2019
antho1404
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.